[Fixed]A new compiler warning in r4143

[mnk]

This revision as added a new compiler warning to the already existing ones.
This one, however sounds far more severe:
source/r_data.cpp: In function ‘void ParseGZLightDef(VScriptParser*, int)’:
source/r_data.cpp:1276: warning: cannot pass objects of non-POD type ‘class VStr’ through ‘...’; call will abort at runtime
source/r_data.cpp:1276: warning: format ‘%s’ expects type ‘char*’, but argument 2 has type ‘int’
(of course, I mean the first part, not the one related to _FORTIFY_SOURCE)

[Firebrand]

Do these appear in the latest revision?

[mnk]

Well, as it was just using va and String together, no (r4154 did change that).

However, looks like I should have posted a full list of warnings - there are a few
in other files too.

So...

a semi-important one

Code: Select all

source/vc_decorate.cpp: In function ‘void ProcessDecorateScripts()’:
source/vc_decorate.cpp:4149: warning: cannot pass objects of non-POD type ‘class VStr’ through ‘...’; call will abort at runtime
source/vc_decorate.cpp:4158: warning: cannot pass objects of non-POD type ‘class VStr’ through ‘...’; call will abort at runtime


just a need for clarification:

Code: Select all

source/vc_package.cpp: In member function ‘void VPackage::WriteObject(const VStr&)’:
source/vc_package.cpp:689: warning: format ‘%6ld’ expects type ‘long int’, but argument 3 has type ‘unsigned int’


There's also a handful of 'format not a string literal and no format arguments', but those I can just ignore
(unless you'd want to fix those too).

[Firebrand]

Closing this then .